yihua commented on code in PR #13602:
URL: https://github.com/apache/hudi/pull/13602#discussion_r2229658159
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/buffer/FileGroupRecordBuffer.java:
##########
@@ -63,7 +67,7 @@
import static
org.apache.hudi.common.model.HoodieRecordMerger.PAYLOAD_BASED_MERGE_STRATEGY_UUID;
import static
org.apache.hudi.common.table.log.block.HoodieLogBlock.HeaderMetadataType.INSTANT_TIME;
-public abstract class FileGroupRecordBuffer<T> implements
HoodieFileGroupRecordBuffer<T> {
+abstract class FileGroupRecordBuffer<T> implements
HoodieFileGroupRecordBuffer<T> {
Review Comment:
We can clean this up later.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/buffer/FileGroupRecordBuffer.java:
##########
@@ -63,7 +67,7 @@
import static
org.apache.hudi.common.model.HoodieRecordMerger.PAYLOAD_BASED_MERGE_STRATEGY_UUID;
import static
org.apache.hudi.common.table.log.block.HoodieLogBlock.HeaderMetadataType.INSTANT_TIME;
-public abstract class FileGroupRecordBuffer<T> implements
HoodieFileGroupRecordBuffer<T> {
+abstract class FileGroupRecordBuffer<T> implements
HoodieFileGroupRecordBuffer<T> {
Review Comment:
Wondering if we should only keep the abstract class `FileGroupRecordBuffer`
and get rid of the interface `HoodieFileGroupRecordBuffer`, which does not seem
to add much value.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -71,28 +66,23 @@
* @param <T> The type of engine-specific record representation, e.g.,{@code
InternalRow}
* in Spark and {@code RowData} in Flink.
*/
-public final class HoodieFileGroupReader<T> implements Closeable {
+public class HoodieFileGroupReader<T> implements Closeable {
Review Comment:
Should this class still be kept `final`? The intention is that the class
should be extended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
