the-other-tim-brown commented on code in PR #13602: URL: https://github.com/apache/hudi/pull/13602#discussion_r2229757240
########## hudi-common/src/main/java/org/apache/hudi/common/table/read/ReaderParameters.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.common.table.read; + +public class ReaderParameters { + private final boolean shouldUseRecordPosition; + private final boolean emitDelete; + private final boolean sortOutput; + // Allows to consider inflight instants while merging log records using HoodieMergedLogRecordReader + // The inflight instants need to be considered while updating RLI records. RLI needs to fetch the revived + // and deleted keys from the log files written as part of active data commit. During the RLI update, + // the allowInflightInstants flag would need to be set to true. This would ensure the HoodieMergedLogRecordReader + // considers the log records which are inflight. + private final boolean allowInflightInstants; + private final boolean enableOptimizedLogBlockScan; + + ReaderParameters(boolean shouldUseRecordPosition, boolean emitDelete, boolean sortOutput, boolean allowInflightInstants, boolean enableOptimizedLogBlockScan) { + this.shouldUseRecordPosition = shouldUseRecordPosition; + this.emitDelete = emitDelete; + this.sortOutput = sortOutput; + this.allowInflightInstants = allowInflightInstants; + this.enableOptimizedLogBlockScan = enableOptimizedLogBlockScan; + } Review Comment: Added a builder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
