danny0405 commented on code in PR #13591:
URL: https://github.com/apache/hudi/pull/13591#discussion_r2233931667
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -444,12 +446,12 @@ public static Map<String, HoodieData<HoodieRecord>>
convertMetadataToRecords(Hoo
// Generate Hoodie Pair data of partition name and list of column range
metadata for all the files in that partition
boolean isDeletePartition =
commitMetadata.getOperationType().equals(WriteOperationType.DELETE_PARTITION);
final HoodieData<HoodieRecord> partitionStatsRDD =
convertMetadataToPartitionStatRecords(commitMetadata, context,
- dataMetaClient, tableMetadata, metadataConfig, recordTypeOpt,
isDeletePartition);
+ dataMetaClient, tableMetadata, metadataConfig, recordTypeOpt,
isDeletePartition, enableOptimizeLogBlocksScan);
partitionToRecordsMap.put(MetadataPartitionType.PARTITION_STATS.getPartitionPath(),
partitionStatsRDD);
}
if
(enabledPartitionTypes.contains(MetadataPartitionType.RECORD_INDEX.getPartitionPath()))
{
partitionToRecordsMap.put(MetadataPartitionType.RECORD_INDEX.getPartitionPath(),
convertMetadataToRecordIndexRecords(context, commitMetadata, metadataConfig,
- dataMetaClient, writesFileIdEncoding, instantTime, engineType));
+ dataMetaClient, writesFileIdEncoding, instantTime, engineType,
enableOptimizeLogBlocksScan));
Review Comment:
> this util method getFileGroupReaderPropertiesFromStorageConf is the
correct way(as it will not be present)
whatever we have, there should be a FG reader props right? in this patch we
can fix it in this way because it's the props been utilized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
