nsivabalan commented on code in PR #13591:
URL: https://github.com/apache/hudi/pull/13591#discussion_r2233368410
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -444,12 +446,12 @@ public static Map<String, HoodieData<HoodieRecord>>
convertMetadataToRecords(Hoo
// Generate Hoodie Pair data of partition name and list of column range
metadata for all the files in that partition
boolean isDeletePartition =
commitMetadata.getOperationType().equals(WriteOperationType.DELETE_PARTITION);
final HoodieData<HoodieRecord> partitionStatsRDD =
convertMetadataToPartitionStatRecords(commitMetadata, context,
- dataMetaClient, tableMetadata, metadataConfig, recordTypeOpt,
isDeletePartition);
+ dataMetaClient, tableMetadata, metadataConfig, recordTypeOpt,
isDeletePartition, enableOptimizeLogBlocksScan);
partitionToRecordsMap.put(MetadataPartitionType.PARTITION_STATS.getPartitionPath(),
partitionStatsRDD);
}
if
(enabledPartitionTypes.contains(MetadataPartitionType.RECORD_INDEX.getPartitionPath()))
{
partitionToRecordsMap.put(MetadataPartitionType.RECORD_INDEX.getPartitionPath(),
convertMetadataToRecordIndexRecords(context, commitMetadata, metadataConfig,
- dataMetaClient, writesFileIdEncoding, instantTime, engineType));
+ dataMetaClient, writesFileIdEncoding, instantTime, engineType,
enableOptimizeLogBlocksScan));
Review Comment:
I looked into this code snippet as well. Agreed that its confusing a bit.
but atleast for RLI, while we are generating MDT RLI records, we are in need
of reading table using FG reader.
and we have to honor writer properties for the data table while reading the
data table file slice using FG reader.
don't think storageConf will have all writer properties set. and hence we
have to pass it from higher layers.
atleast for RLI and SI we have to. I don't see the requirement for other MDT
partitions since none of them involves reading via FG reader.
@danny0405 : let me know if I am missing something here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
