the-other-tim-brown commented on code in PR #13632:
URL: https://github.com/apache/hudi/pull/13632#discussion_r2238018264
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/hudi/SparkAdapter.scala:
##########
@@ -232,7 +231,13 @@ trait SparkAdapter extends Serializable {
def createParquetFileReader(vectorized: Boolean,
sqlConf: SQLConf,
options: Map[String, String],
- hadoopConf: Configuration): SparkParquetReader
+ hadoopConf: Configuration):
SparkColumnarFileReader
+
+ def createOrcFileReader(vectorized: Boolean,
+ sqlConf: SQLConf,
+ options: Map[String, String],
+ hadoopConf: Configuration,
+ dataSchema: StructType): SparkColumnarFileReader
Review Comment:
It's used in the code:
```
val resultedColPruneInfo = OrcUtils.requestedColumnIds(
isCaseSensitive, dataSchema, requiredSchema, orcSchema, conf)
```
I think that we may be able to use the file schema as the data schema though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
