danny0405 commented on code in PR #13632:
URL: https://github.com/apache/hudi/pull/13632#discussion_r2238079640
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/common/SparkReaderContextFactory.java:
##########
@@ -88,18 +92,26 @@ class SparkReaderContextFactory implements
ReaderContextFactory<InternalRow> {
configs.set(SQLConf.PARQUET_OUTPUT_TIMESTAMP_TYPE().key(),
sqlConf.getConfString(SQLConf.PARQUET_OUTPUT_TIMESTAMP_TYPE().key()));
configs.set(SQLConf.PARQUET_WRITE_LEGACY_FORMAT().key(),
sqlConf.getConfString(SQLConf.PARQUET_WRITE_LEGACY_FORMAT().key()));
configurationBroadcast = jsc.broadcast(new
SerializableConfiguration(configs));
- // Broadcast: ParquetReader.
- // Spark parquet reader has to be instantiated on the driver and broadcast
to the executors
- SparkParquetReader parquetFileReader =
sparkAdapter.createParquetFileReader(false, sqlConf, options, configs);
- parquetReaderBroadcast = jsc.broadcast(parquetFileReader);
+ // Broadcast: BaseFilereader.
Review Comment:
let's keep the major work flow simpler first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
