the-other-tim-brown commented on code in PR #13577:
URL: https://github.com/apache/hudi/pull/13577#discussion_r2240788801
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieTimeGeneratorConfig.java:
##########
@@ -56,15 +56,6 @@ public class HoodieTimeGeneratorConfig extends HoodieConfig {
.withDocumentation("The max expected clock skew time in ms between two
processes generating time. Used by "
+ TimeGeneratorType.WAIT_TO_ADJUST_SKEW.name() + " time generator to
implement TrueTime semantics.");
- public static final ConfigProperty<Boolean> TIME_GENERATOR_REUSE_ENABLE =
ConfigProperty
Review Comment:
Yes, the reuse helped because we had 3 paths that could generate lock
providers. Now we are just generating them in the transaction manager so this
is not really needed. The cache was not handling eviction properly as well so
you had resource leaks when the resources were evicted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
