nsivabalan commented on a change in pull request #1704:
URL: https://github.com/apache/hudi/pull/1704#discussion_r536880277



##########
File path: 
hudi-client/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -113,6 +113,9 @@
   public static final String MAX_CONSISTENCY_CHECKS_PROP = 
"hoodie.consistency.check.max_checks";
   public static int DEFAULT_MAX_CONSISTENCY_CHECKS = 7;
 
+  private static final String PAYLOAD_ORDERING_FIELD_PROP = 
"hoodie.payload.ordering.field";

Review comment:
       ok, so for preCombine (combining two records within the same ingestion 
batch) we use one config and for determining ordering among one incoming record 
and another in storage or in other words, to combine an incoming record w/ one 
in storage, we use a diff config? 
   I see both these as one and the same. just that whether we resolve records 
within same batch or across batches is what differs. 
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to