nsivabalan commented on a change in pull request #1704:
URL: https://github.com/apache/hudi/pull/1704#discussion_r538925260
##########
File path:
hudi-client/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -113,6 +113,9 @@
public static final String MAX_CONSISTENCY_CHECKS_PROP =
"hoodie.consistency.check.max_checks";
public static int DEFAULT_MAX_CONSISTENCY_CHECKS = 7;
+ private static final String PAYLOAD_ORDERING_FIELD_PROP =
"hoodie.payload.ordering.field";
Review comment:
similar to how this patch already does. basically we lookup the
preCombine field in existing generic record.
```
Object persistedOrderingVal = getNestedFieldVal((GenericRecord)
currentValue, props.get(ORDERING_FIELD_OPT_KEY), true);
```
Reason I proposed to tweak existing class is.
Even if we want to go w/ 2 classes, Ideally I would want to name existing
class as OverwriteWithIncomingPayload and introduce a new class called
OverwriteWithLatestAvroPayload, bcoz, existing one overwrites w/ incoming and
we are introduce a new class which will actually overwrite w/ latest payload.
But since users configure via class names, we can't go w/ this approach and
hence my proposal to introduce a config and change existing class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
