the-other-tim-brown commented on code in PR #13670:
URL: https://github.com/apache/hudi/pull/13670#discussion_r2249057676
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/buffer/DefaultFileGroupRecordBufferLoader.java:
##########
@@ -42,11 +48,29 @@
class DefaultFileGroupRecordBufferLoader<T> extends
LogScanningRecordBufferLoader implements FileGroupRecordBufferLoader<T> {
Review Comment:
Instead of making this class comply with the new use case, can you make a
new loader that works with an incoming stream of records?
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -70,6 +70,7 @@ public final class HoodieFileGroupReader<T> implements
Closeable {
private final HoodieReaderContext<T> readerContext;
private final HoodieTableMetaClient metaClient;
private final InputSplit inputSplit;
+ private final boolean couldHaveLogFiles;
Review Comment:
Can we instead move this into the InputSplit logic? For example, have a
parameter like "requires base file read" instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
