nsivabalan commented on code in PR #13670:
URL: https://github.com/apache/hudi/pull/13670#discussion_r2250138250
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -70,6 +70,7 @@ public final class HoodieFileGroupReader<T> implements
Closeable {
private final HoodieReaderContext<T> readerContext;
private final HoodieTableMetaClient metaClient;
private final InputSplit inputSplit;
+ private final boolean couldHaveLogFiles;
Review Comment:
I was looking to move this inside `InputSplit`.
but looking at what it tracks and what it is used for, feel 'InputSplit` may
not be the right place to fit this in.
All it contains is, a base file, N log files, partition path and start and
end pos.
Whether to load records from buffer or not, why would `InputSplit` track
that.
Let me know if you guys have a better option on this. If not, I will leave
this as is. ie. exposing `hasLogfiles()` in `FileGroupRecordBufferLoader`
interface only which does not feel out of place to me.
maybe we can rename this variable in HoodieFileGroupReader from
`couldHaveLogFiles` to 'useRecordBufferToInitRecordIterator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
