yihua commented on code in PR #13654:
URL: https://github.com/apache/hudi/pull/13654#discussion_r2268037327
##########
hudi-common/src/test/java/org/apache/hudi/common/table/read/TestHoodieFileGroupReaderBase.java:
##########
@@ -328,15 +328,24 @@ public void
testSchemaEvolutionWhenBaseFilesWithDifferentSchema(HoodieFileFormat
}
}
+ private static Stream<Arguments> testArgsForDifferentBaseAndLogFormats() {
+ boolean supportsORC = supportedFileFormats.contains(HoodieFileFormat.ORC);
+ return Stream.of(
+ arguments(supportsORC ? HoodieFileFormat.ORC :
HoodieFileFormat.PARQUET, "avro"),
+ arguments(HoodieFileFormat.PARQUET, "parquet")
Review Comment:
Should `arguments(HoodieFileFormat.PARQUET, "avro")` always be tested and
`arguments(HoodieFileFormat.ORC, "avro")` be added only is ORC is supported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
