jonvex commented on code in PR #13654:
URL: https://github.com/apache/hudi/pull/13654#discussion_r2269887490
##########
hudi-common/src/test/java/org/apache/hudi/common/table/read/TestHoodieFileGroupReaderBase.java:
##########
@@ -328,15 +328,24 @@ public void
testSchemaEvolutionWhenBaseFilesWithDifferentSchema(HoodieFileFormat
}
}
+ private static Stream<Arguments> testArgsForDifferentBaseAndLogFormats() {
+ boolean supportsORC = supportedFileFormats.contains(HoodieFileFormat.ORC);
+ return Stream.of(
+ arguments(supportsORC ? HoodieFileFormat.ORC :
HoodieFileFormat.PARQUET, "avro"),
+ arguments(HoodieFileFormat.PARQUET, "parquet")
Review Comment:
TBH I think that only `testSchemaEvolutionWhenBaseFilesWithDifferentSchema`
really needs to test both orc and parquet.
The purpose of this test is to ensure that log files can be read with an
evolved schema.
The other tests are to ensure that fg reader can handle base file and log
files with different schemas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
