yihua commented on code in PR #13714:
URL: https://github.com/apache/hudi/pull/13714#discussion_r2271384178


##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroReaderContext.java:
##########
@@ -136,15 +140,27 @@ public ClosableIterator<IndexedRecord> 
getFileRecordIterator(
       Schema requiredSchema,
       HoodieStorage storage) throws IOException {
     HoodieAvroFileReader reader;
+    boolean isLogFile = FSUtils.isLogFile(filePath);
+    Schema fileOutputSchema;
+    Map<String, String> renamedColumns;
+    if (isLogFile) {
+      fileOutputSchema = dataSchema;
+      renamedColumns = Collections.emptyMap();

Review Comment:
   Note to myself: the `FileGroupRecordBuffer` handles the schema-on-read 
evolution with `composeEvolvedSchemaTransformer` for log blocks.  Only parquet 
log blocks requires calling `readerContext.getFileRecordIterator` before 
schema-on-read evolution is applied in `FileGroupRecordBuffer`, thus no need to 
handle schema-on-read in this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to