yihua commented on code in PR #13714:
URL: https://github.com/apache/hudi/pull/13714#discussion_r2271454799
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieAvroFileReader.java:
##########
@@ -48,7 +50,11 @@ protected ClosableIterator<IndexedRecord>
getIndexedRecordIterator(Schema reader
return getIndexedRecordIterator(readerSchema, readerSchema);
}
- public abstract ClosableIterator<IndexedRecord>
getIndexedRecordIterator(Schema readerSchema, Schema requestedSchema) throws
IOException;
+ public ClosableIterator<IndexedRecord> getIndexedRecordIterator(Schema
readerSchema, Schema requestedSchema) throws IOException {
Review Comment:
nit: should this be final so that it should not be overriden?
##########
hudi-common/src/test/java/org/apache/hudi/common/table/read/SchemaHandlerTestBase.java:
##########
@@ -67,6 +68,7 @@ public abstract class SchemaHandlerTestBase {
.map(Schema.Field::name).filter(f ->
!f.equals("_hoodie_is_deleted")).toArray(String[]::new));
protected static final Schema DATA_COLS_ONLY_SCHEMA =
generateProjectionSchema("begin_lat", "tip_history", "rider");
protected static final Schema META_COLS_ONLY_SCHEMA =
generateProjectionSchema("_hoodie_commit_seqno", "_hoodie_record_key");
+ protected final HoodieTableMetaClient metaClient =
mock(HoodieTableMetaClient.class);
Review Comment:
Will the COW merge handle PR #13699 bring tests to cover the changes in this
PR? I'm thinking if that's the fast way to get test coverage on the changes
without (re)writing a lot of tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
