garyli1019 commented on a change in pull request #2296:
URL: https://github.com/apache/hudi/pull/2296#discussion_r539346756
##########
File path: hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -178,11 +178,6 @@ private[hudi] object HoodieSparkSqlWriter {
} else {
hoodieAllIncomingRecords
}
-
- if (hoodieRecords.isEmpty()) {
Review comment:
Hi @pengzhiwei2018 I think this is necessary. It is possible that the
incoming rdd is empty and we need to handle that. Are you seeing any
performance issues here?
Worth to mention that this is the first Spark action, if you are seeing
isEmpty() take too long in Spark UI, it's probably the transformation before
this action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
