pengzhiwei2018 commented on a change in pull request #2296:
URL: https://github.com/apache/hudi/pull/2296#discussion_r539814415
##########
File path: hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -178,11 +178,6 @@ private[hudi] object HoodieSparkSqlWriter {
} else {
hoodieAllIncomingRecords
}
-
- if (hoodieRecords.isEmpty()) {
Review comment:
Hi @garyli1019 ,In our case,the incoming rdd is very complex, this
`isEmpty` test spend so much time.And if the incoming rdd is empty, the code
that follows will execute quickly.So I think this `isEmpty` test is unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
