nsivabalan commented on code in PR #13699:
URL: https://github.com/apache/hudi/pull/13699#discussion_r2279133779
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/SecondaryIndexStreamingTracker.java:
##########
@@ -226,6 +228,81 @@ static <T> void trackSecondaryIndexStats(@Nullable
HoodieKey hoodieKey, Option<H
});
}
+ /**
+ * The utility function used by Merge Handle to generate secondary index
stats for the corresponding record.
+ * It considers the new merged version of the record and compares it with
the older version of the record to generate
+ * secondary index stats.
+ *
+ * @param hoodieKey The hoodie key
+ * @param combinedRecordOpt New record merged with the old record
+ * @param oldRecord The old record
+ * @param isDelete Whether the record is a DELETE
+ * @param writeStatus The Write status
+ * @param secondaryIndexDefns Definitions for secondary index which
need to be updated
+ */
+ static <T> void trackSecondaryIndexStats(HoodieKey hoodieKey,
Option<BufferedRecord<T>> combinedRecordOpt, @Nullable BufferedRecord<T>
oldRecord, boolean isDelete,
Review Comment:
if we have not added UTs for this, can you track it in a follow up jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
