nsivabalan commented on code in PR #13699:
URL: https://github.com/apache/hudi/pull/13699#discussion_r2279570809
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/testutils/MetadataMergeWriteStatus.java:
##########
@@ -60,12 +60,12 @@ private static void mergeMetadataMaps(Map<String, String>
mergeFromMap, Map<Stri
if (!mergeToMap.containsKey(key)) {
mergeToMap.put(key, "0");
}
- mergeToMap.put(key, addStrsAsInt(entry.getValue(), mergeToMap.get(key)));
+ mergeToMap.put(key, addStrsAsLong(entry.getValue(),
mergeToMap.get(key)));
}
}
- private static String addStrsAsInt(String a, String b) {
- return String.valueOf(Integer.parseInt(a) + Integer.parseInt(b));
+ private static String addStrsAsLong(String a, String b) {
+ return String.valueOf(Long.parseLong(a) + Long.parseLong(b));
Review Comment:
I triaged this.
looks like the event time metadata tracking could have been broken only if
not for this fix. I am not sure if someone was ever using this feature only.
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/testutils/MetadataMergeWriteStatus.java:
##########
@@ -60,12 +60,12 @@ private static void mergeMetadataMaps(Map<String, String>
mergeFromMap, Map<Stri
if (!mergeToMap.containsKey(key)) {
mergeToMap.put(key, "0");
}
- mergeToMap.put(key, addStrsAsInt(entry.getValue(), mergeToMap.get(key)));
+ mergeToMap.put(key, addStrsAsLong(entry.getValue(),
mergeToMap.get(key)));
}
}
- private static String addStrsAsInt(String a, String b) {
- return String.valueOf(Integer.parseInt(a) + Integer.parseInt(b));
+ private static String addStrsAsLong(String a, String b) {
+ return String.valueOf(Long.parseLong(a) + Long.parseLong(b));
Review Comment:
whats this fix is about?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
