danny0405 commented on code in PR #13650:
URL: https://github.com/apache/hudi/pull/13650#discussion_r2300693715
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/RecordContext.java:
##########
@@ -335,6 +336,15 @@ private SerializableBiFunction<T, Schema, String>
metadataKeyExtractor() {
}
private SerializableBiFunction<T, Schema, String>
virtualKeyExtractor(String[] recordKeyFields) {
+ if (recordKeyFields.length == 1) {
+ return (record, schema) -> {
+ Object result = getValue(record, schema, recordKeyFields[0]);
+ if (result == null) {
+ throw new HoodieKeyException("recordKey cannot be null");
+ }
+ return result.toString();
Review Comment:
If we have no use cases for COW write into data table that disable the
metadata fields, it should be good, otherwise, the write path key extraction
and the base file could be different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
