danny0405 commented on code in PR #13650:
URL: https://github.com/apache/hudi/pull/13650#discussion_r2300720988
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/EightToNineUpgradeHandler.java:
##########
@@ -107,6 +110,10 @@ public UpgradeDowngrade.TableConfigChangeSet
upgrade(HoodieWriteConfig config,
Set<ConfigProperty> tablePropsToRemove = new HashSet<>();
HoodieTableMetaClient metaClient = table.getMetaClient();
HoodieTableConfig tableConfig = metaClient.getTableConfig();
+ if (config.enableComplexKeygenValidation()
+ && isComplexKeyGeneratorWithSingleRecordKeyField(tableConfig)) {
+ throw new HoodieException(getComplexKeygenErrorMessage("upgrade"));
Review Comment:
do you think we also need to check the write config flag? if user sets it as
false explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
