the-other-tim-brown commented on code in PR #13742:
URL: https://github.com/apache/hudi/pull/13742#discussion_r2300856120
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/BufferedRecordMergerFactory.java:
##########
@@ -517,20 +502,21 @@ protected Pair<HoodieRecord, HoodieRecord>
getFinalMergeRecords(BufferedRecord<T
return getDeltaMergeRecords(olderRecord, newerRecord);
}
- protected Option<Pair<HoodieRecord, Schema>>
getMergedRecord(BufferedRecord<T> olderRecord, BufferedRecord<T> newerRecord,
boolean isFinalMerge) throws IOException {
+ protected Pair<HoodieRecord, Schema> getMergedRecord(BufferedRecord<T>
olderRecord, BufferedRecord<T> newerRecord, boolean isFinalMerge) throws
IOException {
Pair<HoodieRecord, HoodieRecord> records = isFinalMerge ?
getFinalMergeRecords(olderRecord, newerRecord) :
getDeltaMergeRecords(olderRecord, newerRecord);
return recordMerger.merge(records.getLeft(),
getSchemaForAvroPayloadMerge(olderRecord), records.getRight(),
getSchemaForAvroPayloadMerge(newerRecord), props);
}
protected HoodieRecord constructHoodieAvroRecord(RecordContext<T>
recordContext, BufferedRecord<T> bufferedRecord, String payloadClass) {
GenericRecord record = null;
- if (!bufferedRecord.isDelete()) {
+ if (bufferedRecord.getRecord() != null) {
Schema recordSchema =
recordContext.getSchemaFromBufferRecord(bufferedRecord);
record = recordContext.convertToAvroRecord(bufferedRecord.getRecord(),
recordSchema);
}
HoodieKey hoodieKey = new HoodieKey(bufferedRecord.getRecordKey(), null);
+ Comparable orderingValue =
recordContext.convertOrderingValueFromEngineType(bufferedRecord.getOrderingValue());
Review Comment:
Any suggestions? The payloads do not use the engine specific types leading
to type cast issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
