linliu-code commented on code in PR #13742:
URL: https://github.com/apache/hudi/pull/13742#discussion_r2301970989
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/common/model/HoodieSparkRecord.java:
##########
@@ -257,7 +258,11 @@ public HoodieRecord truncateRecordKey(Schema recordSchema,
Properties props, Str
@Override
protected boolean checkIsDelete(Schema recordSchema, Properties props) {
- if (null == data) {
+ if (data == null) {
+ return true;
+ }
+
+ if (HoodieOperation.isDelete(getOperation())) {
return true;
}
Review Comment:
Should we just combine into one `if` statement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
