jonvex commented on code in PR #13711:
URL: https://github.com/apache/hudi/pull/13711#discussion_r2301104401


##########
hudi-common/src/main/avro/HoodieMetadata.avsc:
##########
@@ -417,6 +417,35 @@
                             "name": "isTightBound",
                             "type": "boolean",
                             "default": false
+                        },
+                        {
+                            "doc": "Value type information containing enum 
ordinal and optional additional information",

Review Comment:
   ValueMetadata has several static methods `getValueMetadata` that can be used 
on avro schema, avro parquet type,  or `HoodieValueTypeInfo` contained in a 
HoodieMetadata col stats record. 
   
   
https://github.com/apache/incubator-xtable/blob/9f989bf1988bf9ce29f66bd2a9fe04bb4db73c6a/xtable-api/src/main/java/org/apache/xtable/model/stat/Range.java#L60
   The docs here say that timestamps are using some internal type. So seems 
like some conversion will be necessary in xtable. 
   
   
   And the utils here need to be updated:
   
https://github.com/apache/incubator-xtable/blob/main/xtable-core/src/main/java/org/apache/xtable/hudi/HudiFileStatsExtractor.java



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to