yihua commented on code in PR #13711:
URL: https://github.com/apache/hudi/pull/13711#discussion_r2302273332
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -257,7 +257,8 @@ public static Map<String,
HoodieColumnRangeMetadata<Comparable>> collectColumnRa
List<Pair<String, Schema.Field>> targetFields,
String filePath,
Schema recordSchema,
- StorageConfiguration<?> storageConfig) {
+ StorageConfiguration<?> storageConfig,
+ HoodieIndexVersion indexVersion) {
Review Comment:
Could the col stats V1 and V2 logic be separated into two methods,
`collectColumnRangeMetadataV1` and `collectColumnRangeMetadataV2`? In the
future after #13226 is landed, the logic should be contained in
`ColumnStatsIndexer` and there will be version-specific indexer implementation.
So by doing this, it's easier for future refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
