lw309637554 commented on pull request #2263: URL: https://github.com/apache/hudi/pull/2263#issuecomment-744018999
> > @satishkotha high level 2 outstanding questions > > a) Moving sortKey into HoodieRecord is needed only if we see performance degradation in conversion, if not we can keep it that way > > b) Keep the old way of reading file slice with and without log files as long as no memory overhead for without log files > > @n3nash Both of these are performance related. My guess is this takes 3-4 weeks to test out with proper setup at scale (there are some issues because of separate branches etc). I think I addressed all of your other comments and fixed few issues I found with small scale. > > Let me know if you have any other feedback. @satishkotha i also plan to do some performance test, such as kafka message large-scale insert and then clustering period. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
