satishkotha commented on a change in pull request #2263:
URL: https://github.com/apache/hudi/pull/2263#discussion_r545554989
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/AbstractBulkInsertHelper.java
##########
@@ -27,8 +27,21 @@
public abstract class AbstractBulkInsertHelper<T extends HoodieRecordPayload,
I, K, O, R> {
+ /**
+ * Mark instant as inflight, write input records, update index and return
result.
+ */
public abstract HoodieWriteMetadata<O> bulkInsert(I inputRecords, String
instantTime,
HoodieTable<T, I, K, O>
table, HoodieWriteConfig config,
BaseCommitActionExecutor<T, I, K, O, R> executor, boolean performDedupe,
Option<BulkInsertPartitioner<T>> userDefinedBulkInsertPartitioner);
+
+ /**
+ * Only write input records. Does not change timeline/index. Return
information about new files created.
+ */
+ public abstract O bulkInsert(I inputRecords, String instantTime,
+ HoodieTable<T, I, K, O> table,
HoodieWriteConfig config,
+ boolean performDedupe,
+ Option<BulkInsertPartitioner<T>>
userDefinedBulkInsertPartitioner,
+ boolean addMetadataFields,
+ int numOutputGroups);
Review comment:
Looks like I already changed subclasses, but overlooked base class.
Thanks for catching this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
