alexr17 commented on code in PR #13836:
URL: https://github.com/apache/hudi/pull/13836#discussion_r2331678490
##########
hudi-aws/src/main/java/org/apache/hudi/aws/transaction/lock/S3StorageLockClient.java:
##########
@@ -94,25 +92,13 @@ public S3StorageLockClient(String ownerId, String
lockFileUri, Properties props)
@VisibleForTesting
S3StorageLockClient(String ownerId, String lockFileUri, Properties props,
Functions.Function2<String, Properties, S3Client> s3ClientSupplier, Logger
logger) {
- try {
- // This logic can likely be extended to other lock client
implementations.
- // Consider creating base class with utilities, incl error handling.
- URI uri = new URI(lockFileUri);
- this.bucketName = uri.getHost();
Review Comment:
yes, we can do that here too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
