yihua commented on code in PR #13836:
URL: https://github.com/apache/hudi/pull/13836#discussion_r2331673626
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/transaction/lock/TestStorageBasedLockProvider.java:
##########
@@ -679,22 +685,22 @@ public void
testStorageBasedLockProviderWithMetricsConstructor() {
assertThrows(Exception.class, () -> {
new StorageBasedLockProvider(lockConfiguration, storageConf,
mockMetrics);
}, "Constructor should exist but fail during lock client instantiation");
-
+
// Now create a working instance using the internal constructor for
proper validation
lockProviderWithMetrics = new StorageBasedLockProvider(
- UUID.randomUUID().toString(),
- props,
- (a,b,c) -> mock(HeartbeatManager.class),
- (a,b,c) -> new StubStorageLockClient(a, b, new Properties()),
- mock(Logger.class),
- mockMetrics);
-
+ UUID.randomUUID().toString(),
Review Comment:
Similar to double check the indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
