danny0405 commented on code in PR #13650:
URL: https://github.com/apache/hudi/pull/13650#discussion_r2354543901
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/ComplexAvroKeyGenerator.java:
##########
@@ -43,9 +45,16 @@ public ComplexAvroKeyGenerator(TypedProperties props) {
.map(String::trim)
.filter(s -> !s.isEmpty())
.collect(Collectors.toList());
- this.recordKeyFunction = ConfigUtils.getBooleanWithAltKeys(props,
COMPLEX_KEYGEN_OLD_ENCODING)
- ? record -> KeyGenUtils.getRecordKey(record, getRecordKeyFieldNames(),
isConsistentLogicalTimestampEnabled())
- : this::getRecordKeyWithoutKeyFieldNameOnSingleKeyField;
+ // Get table version
+ Integer tableVersionCode = ConfigUtils.getIntWithAltKeys(props,
WRITE_TABLE_VERSION);
+ HoodieTableVersion tableVersion =
HoodieTableVersion.fromVersionCode(tableVersionCode);
+ // Determine which encoding to use
+ boolean useNewEncodingForSingleKey =
tableVersion.lesserThan(HoodieTableVersion.NINE)
Review Comment:
so for table version 9 we already use the old encoding? can we create a task
to trace that we will unify the encoding by introducing a new key generator
class in 1.2 release(that takes the new encoding for new created table)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
