danny0405 commented on code in PR #13650:
URL: https://github.com/apache/hudi/pull/13650#discussion_r2354591103
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/RecordContext.java:
##########
@@ -416,6 +417,15 @@ private SerializableBiFunction<T, Schema, String>
metadataKeyExtractor() {
}
private SerializableBiFunction<T, Schema, String>
virtualKeyExtractor(String[] recordKeyFields) {
+ if (recordKeyFields.length == 1) {
+ return (record, schema) -> {
Review Comment:
can we add some doc that there might be consistency for record key encoding
when partition fields are multiple for cow merging, currently the incoming
records are using the keys from `HoodieRecord` which utilities the write config
and by default encodes the field name with the value while here the field names
are missing, this function would be use used to extract record keys from old
base file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]