jonvex commented on code in PR #13711:
URL: https://github.com/apache/hudi/pull/13711#discussion_r2355856658
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestSparkSortAndSizeClustering.java:
##########
@@ -182,9 +183,9 @@ private void validateDateAndTimestampFields(List<Row> rows,
long ts) {
assertTrue(actualDate.compareTo(startDate) > 0 &&
actualDate.compareTo(endDate) < 0);
}
if (!row.isNullAt(tsLocalMillisFieldIndex)) {
- assertEquals(ts, row.get(tsLocalMillisFieldIndex));
+ assertEquals(ValueType.toLocalTimestampMillis(ts, null),
row.get(tsLocalMillisFieldIndex));
}
- assertEquals(ts * 1000L, row.get(tsLocalMicrosFieldIndex));
+ assertEquals(ValueType.toLocalTimestampMillis(ts, null),
row.get(tsLocalMicrosFieldIndex));
Review Comment:
ts is in millis. That's why previously it was multiplied by 1000. LocalTS
are all represented by LocalDateTime. So What I have is equivalent to
ValueType.toLocalTimestampMicros(ts * 1000L, null). I can change it to that if
you think it's more clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
