jonvex commented on code in PR #13711:
URL: https://github.com/apache/hudi/pull/13711#discussion_r2352914972
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowParquetWriteSupport.java:
##########
@@ -451,7 +451,7 @@ private Type convertField(Schema avroFieldSchema,
StructField structField, Type.
.as(LogicalTypeAnnotation.timestampType(false,
LogicalTypeAnnotation.TimeUnit.MICROS)).named(structField.name());
} else if
(logicalType.getName().equals(LogicalTypes.localTimestampMillis().getName())) {
return Types.primitive(INT64, repetition)
- .as(LogicalTypeAnnotation.timestampType(false,
LogicalTypeAnnotation.TimeUnit.MICROS)).named(structField.name());
+ .as(LogicalTypeAnnotation.timestampType(false,
LogicalTypeAnnotation.TimeUnit.MILLIS)).named(structField.name());
Review Comment:
Yes, Tim's test was failing. He fixed the writer, but was validating with
the spark reader, which also has issues that I fixed. So that's why the test is
passing on master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
