danny0405 commented on code in PR #13951:
URL: https://github.com/apache/hudi/pull/13951#discussion_r2366653044
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java:
##########
@@ -140,6 +142,9 @@ protected HoodieWriteHandle(HoodieWriteConfig config,
String instantTime, String
&& hoodieTable.getMetaClient().getTableConfig().getRecordMergeMode()
== EVENT_TIME_ORDERING
&& ConfigUtils.isTrackingEventTimeWatermark(config.getProps());
this.keepConsistentLogicalTimestamp = isTrackingEventTimeWatermark &&
ConfigUtils.shouldKeepConsistentLogicalTimestamp(config.getProps());
+ TypedProperties mergeProps = ConfigUtils.getMergeProps(config.getProps(),
hoodieTable.getMetaClient().getTableConfig());
+ Schema deleteContextSchema = preserveMetadata ? writeSchemaWithMetaFields
: writeSchema;
+ this.deleteContext = new DeleteContext(mergeProps,
deleteContextSchema).withReaderSchema(deleteContextSchema);
Review Comment:
I guess the reason we do not use `DeleteContext #fromRecordSchema` here is
because it can be eigher used in read or write path, makes sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
