nsivabalan commented on code in PR #13967:
URL: https://github.com/apache/hudi/pull/13967#discussion_r2370634588
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/others/TestMergeIntoTable.scala:
##########
@@ -1688,4 +1688,75 @@ class TestMergeIntoTable extends HoodieSparkSqlTestBase
with ScalaAssertionSuppo
}
}
}
+
+ test("Test partition not at end") {
+ withSQLConf("hoodie.memory.merge.max.size" -> "1",
+ "hoodie.memory.compaction.max.size" -> "1",
+ "hoodie.insert.shuffle.parallelism" -> "1",
+ "hoodie.upsert.shuffle.parallelism" -> "1",
+ "hoodie.bulkinsert.shuffle.parallelism" -> "1") {
Review Comment:
can we write a test that actually spills.
guess this test will succeed even w/o your fix right?
essentially, the test should fail w/o your fix and should succeed w/ this
fix.
what incase someone reverts your changes down the line due to some
refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
