voonhous commented on code in PR #13991:
URL: https://github.com/apache/hudi/pull/13991#discussion_r2378120491
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/LockManager.java:
##########
@@ -115,9 +115,8 @@ public synchronized LockProvider getLockProvider() {
if (ReflectionUtils.hasConstructor(writeConfig.getLockProviderClass(),
metricsConstructorTypes)) {
lockProvider = (LockProvider)
ReflectionUtils.loadClass(writeConfig.getLockProviderClass(),
metricsConstructorTypes, lockConfiguration, storageConf, metrics);
- LOG.debug("Successfully loaded LockProvider with HoodieLockMetrics
support");
} else {
- LOG.debug("LockProvider does not support HoodieLockMetrics
constructor, falling back to standard constructor");
+ LOG.debug("LockProvider does not support HoodieLockMetrics param in
constructor, falling back to standard constructor");
// Fallback to original constructor without metrics
lockProvider = (LockProvider)
ReflectionUtils.loadClass(writeConfig.getLockProviderClass(),
new Class<?>[] {LockConfiguration.class,
StorageConfiguration.class},
Review Comment:
Got it, thanks for the clarification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
