voonhous commented on PR #13991: URL: https://github.com/apache/hudi/pull/13991#issuecomment-3332579559
Do you think we need some cleanup for the `LockProvider` implementation providers? IIUC, we are doing this sort of streaming to ensure backwards compatibility right? If this is the case, is it possible to add a new construct with the `HoodieLockMetrics` parameter for all `LockProvider` implementations? For those that do not require using it, it can then call the overloaded constructor without the `HoodieLockMetrics` constructor similar to what you are doing for `FileSystemBasedLockProvider`. With this, we can remove the else block of the ReflectionsUtil that we are modifying here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
