vinothchandar commented on a change in pull request #2343:
URL: https://github.com/apache/hudi/pull/2343#discussion_r546313057
##########
File path:
hudi-client/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -72,6 +72,7 @@
public static final String BULKINSERT_USER_DEFINED_PARTITIONER_CLASS =
"hoodie.bulkinsert.user.defined.partitioner.class";
public static final String UPSERT_PARALLELISM =
"hoodie.upsert.shuffle.parallelism";
public static final String DELETE_PARALLELISM =
"hoodie.delete.shuffle.parallelism";
+ public static final String FILE_LISTING_PARALLELISM =
"hoodie.file.listing.shuffle.parallelism";
Review comment:
I think we can drop `.shuffle`
##########
File path:
hudi-client/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -51,6 +51,7 @@
import org.apache.hudi.common.util.HoodieTimer;
import org.apache.hudi.common.util.Option;
import org.apache.hudi.common.util.ValidationUtils;
+import org.apache.hudi.common.util.collection.Pair;
Review comment:
We can pass in the `HoodieEngineContext` which can also be plain old
java if needed. I ll take a closer look in #2351 and how best we can do this.
We can scope this PR to just what you just fixed now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
