vamsikarnika commented on code in PR #14112:
URL: https://github.com/apache/hudi/pull/14112#discussion_r2442447908
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java:
##########
@@ -314,6 +314,12 @@ protected HoodieLogFormat.Writer createLogWriter(String
instantTime, String file
Option<HoodieLogFile> latestLogFile = fileSliceOpt.isPresent()
? fileSliceOpt.get().getLatestLogFile()
: Option.empty();
+
+ // Compute the next log file version: use latest version + 1 if
available and append is not supported,
Review Comment:
@danny0405 I see that we're always rolling over to the next log if current
log file exists when writing for the first time. I see that append to existing
log file is not supported.
https://github.com/vamsikarnika/hudi/blob/d4d719d45dfc7e55870590e03a53281b246d755b/hudi-hadoop-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java#L106
@nsivabalan Originally this change was intended to get rid of the
unnecessary filesystem call to fetch the latest log version. But looks like
we're not making that file system call anymore. We simply increase the
fileversion, and if some other writer has written same og file, writer fails to
createFile and simply moves to next log version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
