nsivabalan commented on code in PR #14112:
URL: https://github.com/apache/hudi/pull/14112#discussion_r2442774607
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java:
##########
@@ -314,6 +314,12 @@ protected HoodieLogFormat.Writer createLogWriter(String
instantTime, String file
Option<HoodieLogFile> latestLogFile = fileSliceOpt.isPresent()
? fileSliceOpt.get().getLatestLogFile()
: Option.empty();
+
+ // Compute the next log file version: use latest version + 1 if
available and append is not supported,
Review Comment:
I see we have optimized the `rollover` logic in 1.1 even for table version 6
compared to say 0.14.1.
Here is 0.14.1 rollover logic
https://github.com/apache/hudi/blob/5b0d67bc79852b16eb8de12e74c8087abba13bb3/hudi-common/src/main/java/org/apache/hudi/common/model/HoodieLogFile.java#L190
which does fs listing.
while in latest master,
https://github.com/apache/hudi/blob/d4d719d45dfc7e55870590e03a53281b246d755b/hudi-common/src/main/java/org/apache/hudi/common/model/HoodieLogFile.java#L184
Considering this, this fix may not be required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
