nsivabalan commented on code in PR #13964:
URL: https://github.com/apache/hudi/pull/13964#discussion_r2374762925
##########
hudi-common/src/test/java/org/apache/hudi/common/table/read/buffer/TestKeyBasedFileGroupRecordBuffer.java:
##########
@@ -168,7 +168,8 @@ void readWithEventTimeOrderingWithRecords() throws
IOException {
// update for 4 is ignored due to lower ordering value.
// record5 is deleted.
// delete for 6 is ignored due to lower ordering value.
- assertEquals(Arrays.asList(testRecord1UpdateWithSameTime,
testRecord2Update, testRecord3Update, testRecord4, testRecord6, testRecord7),
actualRecords);
+
assertEquals(Arrays.asList(getSerializableIndexedRecord(testRecord1UpdateWithSameTime),
getSerializableIndexedRecord(testRecord2Update),
Review Comment:
not every record is expected to be `SerializableIndexedRecord`. based on
whether record from base file is chosen or from the incoming records.
So, can't really go w/ `Stream.of(...).map`
but I can employ this below wherever applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
