voonhous commented on code in PR #13927:
URL: https://github.com/apache/hudi/pull/13927#discussion_r2390940146
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/common/HoodieSparkEngineContext.java:
##########
@@ -260,7 +260,7 @@ public <I, O> O aggregate(HoodieData<I> data, O zeroValue,
Functions.Function2<O
public ReaderContextFactory<?> getReaderContextFactory(HoodieTableMetaClient
metaClient) {
// metadata table are only supported by the AvroReaderContext.
if (metaClient.isMetadataTable()) {
- return new AvroReaderContextFactory(metaClient);
+ return new AvroReaderContextFactory(metaClient, new TypedProperties());
Review Comment:
Metadata writer can use leverage cache configs. It is not currently using
this method for creating an `AvroReaderContextFactory`.
Instead, it is using:
```
org.apache.hudi.common.engine.HoodieEngineContext#getReaderContextFactoryForWrite
```
Which is able to pass in hfile cache configs. The other callers that are
using `AvroReaderContextFactory((metaClient, new TypedProperties())` will have
their behaviour remain unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
