yihua commented on code in PR #14120:
URL: https://github.com/apache/hudi/pull/14120#discussion_r2443858952


##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieParquetFileFormatHelper.scala:
##########
@@ -140,6 +202,7 @@ object HoodieParquetFileFormatHelper {
           Cast(expr, dec, if (needTimeZone) timeZoneId else None)
         case (StringType, DateType) =>
           Cast(expr, DateType, if (needTimeZone) timeZoneId else None)
+        case (LongType, TimestampNTZType) => expr // @ethan I think we just 
want a no-op here?

Review Comment:
   Now I kind of get it.  Is this because the local timestamp or 
TimestampNTZType is written as Long type in parquet before? Also, there is no 
regression micros in schema vs millis in values for TimestampNTZType for 
published Hudi releases correct?  If so, there is no need for conversion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to