danny0405 commented on code in PR #14120:
URL: https://github.com/apache/hudi/pull/14120#discussion_r2446632913
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieCommonConfig.java:
##########
@@ -54,6 +54,14 @@ public class HoodieCommonConfig extends HoodieConfig {
.markAdvanced()
.withDocumentation("Enables support for Schema Evolution feature");
+ public static final ConfigProperty<Boolean>
SCHEMA_EVOLUTION_ALLOW_LOGICAL_EVOLUTION = ConfigProperty
+ .key("hoodie.schema.evolution.allow.logical.evolution")
Review Comment:
Then why we need this flag if the precision loss is never allowed in schema
evolution. Just abadon the converion in the code?
BTW, not only timestamp type got logical types in avro schema right? and I
didn't see it works for preventing precision loss from this name. At least type
promotion should be allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
