yihua commented on code in PR #14120:
URL: https://github.com/apache/hudi/pull/14120#discussion_r2449005279
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieDataBlock.java:
##########
@@ -282,7 +283,8 @@ protected <T> ClosableIterator<HoodieRecord<T>>
readRecordsFromBlockPayload(Hood
}
try {
- return deserializeRecords(getContent().get(), type);
+ return deserializeRecords(getContent().get(), type,
getBlockContentLocation()
Review Comment:
@jonvex for deserialization of log records that contains the incorrect
logical timestamp-micros type after validating the mismatch against the table
schema, the schema to deserialize the record should be adjusted based on the
write schema in the log block header, by changing the logical timestamp-micros
to timestamp-millis. Then, there is no need to incur schema evolution logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
