danny0405 commented on code in PR #14120:
URL: https://github.com/apache/hudi/pull/14120#discussion_r2450257369
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -952,9 +952,10 @@ public void validateSchema() throws HoodieUpsertException,
HoodieInsertException
if (!existingTableSchema.isPresent()) {
return;
}
+ boolean allowLogicalEvolutions = config.shouldAllowLogicalEvolutions();
Review Comment:
Like we discussed:
https://github.com/apache/hudi/pull/14120/files#r2448965924, for V9 table, the
flag `allowLogicalEvolutions` should always be false while for V8 and below, it
should be true to allow the fix to work.
So that we can get rid of the option `config.shouldAllowLogicalEvolutions()`
and just decide by table version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
