vinothchandar commented on pull request #2342: URL: https://github.com/apache/hudi/pull/2342#issuecomment-749435267
>If this is the case what happens when c3 and c4 are then finally synced? These files would remain in the metadata table even though rollback should have removed them So restore in that example, would delete C3, C4 from the timeline. it won't be synced at all. >How do we differentiate this from a bug which lead to files missing from the metadata listing? The current merge code provides some sort of correctness - deletes are always for files already created. I think we should maintain this. I understand the need for wanting to fail-fast. but the scenario above is legit, right? Do you suggest we sync the rollbacks only if the original instants for which the rollback was done were synced to the metadata table? cc @prashantwason Let's make the call on this one. Otherwise PR seems ready more or less, after another rebase/set of comments. ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
