the-other-tim-brown opened a new pull request, #14314:
URL: https://github.com/apache/hudi/pull/14314
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
Addresses https://github.com/apache/hudi/issues/14269
The `AvroInternalSchemaConverter` currently directly relies on an Avro
schema. This PR switches the class to operate on `HoodieSchema` as part of the
migration to Hoodie's own type system.
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
- `AvroInternalSchemaConverter` is renamed to `InternalSchemaConverter`
- All methods in `InternalSchemaConverter` now take `HoodieSchema` instead
of an avro schema
- Callers of these methods convert their avro schema to `HoodieSchema` with
the `fromAvroSchema` method
- Related test cases are update to directly construct `HoodieSchema`
directly when possible
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
This is laying the groundwork for moving the codebase over to Hudi's own
type system.
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
Low, this maintains parity with the existing code
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
