the-other-tim-brown commented on code in PR #14314:
URL: https://github.com/apache/hudi/pull/14314#discussion_r2550146279
##########
hudi-common/src/main/java/org/apache/hudi/common/schema/HoodieSchema.java:
##########
@@ -402,12 +403,12 @@ public Option<String> getNamespace() {
}
/**
- * Returns the full name of this schema (namespace + name).
+ * Returns the full name of this schema (namespace + name) if a record, or
the type name otherwise.
*
- * @return Option containing the full schema name, or Option.empty() if none
+ * @return The full schema name, or name of the type if not a record
*/
- public Option<String> getFullName() {
- return Option.ofNullable(avroSchema.getFullName());
+ public String getFullName() {
Review Comment:
The name is always meant to be non-empty in avro and I think we should
follow a similar pattern here or we end up with a lot of option handling code
in the callers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
