yihua commented on code in PR #14314:
URL: https://github.com/apache/hudi/pull/14314#discussion_r2553275029
##########
hudi-common/src/main/java/org/apache/hudi/internal/schema/convert/InternalSchemaConverter.java:
##########
@@ -64,65 +63,65 @@ public class AvroInternalSchemaConverter {
//
// This is crucial aspect of maintaining compatibility b/w schemas,
after
// converting Avro [[Schema]]s to [[InternalSchema]]s and back
- private static final String AVRO_NAME_DELIMITER = ".";
+ private static final String FIELD_NAME_DELIMITER = ".";
Review Comment:
Should the Avro-related comments on L56-65 be updated or removed?
##########
hudi-common/src/main/java/org/apache/hudi/internal/schema/convert/InternalSchemaConverter.java:
##########
@@ -64,65 +63,65 @@ public class AvroInternalSchemaConverter {
//
// This is crucial aspect of maintaining compatibility b/w schemas,
after
// converting Avro [[Schema]]s to [[InternalSchema]]s and back
- private static final String AVRO_NAME_DELIMITER = ".";
+ private static final String FIELD_NAME_DELIMITER = ".";
/**
- * Convert internalSchema to avro Schema.
+ * Convert internalSchema to HoodieSchema.
*
* @param internalSchema internal schema.
* @param name the record name.
- * @return an avro Schema.
+ * @return an HoodieSchema.
*/
- public static Schema convert(InternalSchema internalSchema, String name) {
- return buildAvroSchemaFromInternalSchema(internalSchema, name);
+ public static HoodieSchema convert(InternalSchema internalSchema, String
name) {
+ return buildHoodieSchemaFromInternalSchema(internalSchema, name);
Review Comment:
General question for my understanding: do we plan to replace
`InternalSchema` with `HoodieSchema` eventually so that `HoodieSchema` will
also contain the representation of the internal schema for schema evolution on
read and the related utils to convert the internal schema to the storage
representation in `.hoodie/.schema`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
